#2309 Scheduled runs that suspend on an approval gate are logged as failures

Found while triaging swamp-club#2303; deliberately left out of that fix, which is scoped to the webhook path.

Summary

A scheduled workflow containing an approval step suspends rather than completing. ScheduledExecutionService does not recognise that outcome and reports the run as a failure.

Cause

src/libswamp/workflows/scheduled_execution.ts:610-631 captures the started, completed, cancelled and error events from the run stream, but not suspended. A suspended run therefore leaves the completed run view unset and no stream error recorded, so it falls into the final else arm and is logged at error level with the message about the workflow not completing, and emits schedule_failed. That event feeds runMetricsTracker with the failed bucket, so the health endpoint counts a failure for a run that is merely waiting on an approver.

Expected

A suspended scheduled run is not reported as a failure and does not record a failed health entry.

Note

The fix for swamp-club#2303 gives the webhook arm an explicit suspended branch. Once that lands the webhook and scheduled arms will differ, and the webhook one is the correct model to copy here.