Skip to main content
← Back to list
01Issue
BugShippedSwamp CLIPublic
Assigneesstack72

Relationships

#2426 serve: vault edit over --server opens an editor on the server host and ignores the managedConfig vaults dir

Opened by hammz · 9/23/2026· Shipped 9/29/2026

Description

handleVaultEdit (src/serve/handlers/vault_handlers.ts) runs the same vaultEdit generator as the local CLI, using createVaultEditDeps(ctx.repoDir) (src/libswamp/vaults/edit.ts). Two problems follow:

  1. The editor runs on the server. prepareEditor / launch.open() start EDITOR (or the platform opener) on the serve host, not on the client. A remote swamp vault edit --server cannot edit anything, and on a desktop host it opens a window on the wrong machine.
  2. It ignores managedConfig. getVaultPath hard-codes join(repoDir, "vaults", type, id + ".yaml"). It should use the effective vaults dir: config/vaults/ in the datastore tier when managedConfig is on. findByName goes through YamlVaultConfigRepository, which does resolve the managed dir, so the lookup succeeds but fileExists then fails on the repo-local path and the handler returns not-found.

Expected

A remote vault edit either returns the config content for the client to edit and accepts the edited content back, or the server rejects vault.edit with a clear unsupported error. In both cases the managed vaults dir should be respected.

Found while auditing swamp-club#2415. That issue removes the handler's no-op datastore push, but leaves this behaviour alone.

02Bog Flow
✓OPEN✓TRIAGED✓IN PROGRESS✓SHIPPEDTRIAGE+ 14 MOREREVIEW+ 10 MOREPR_MERGED+ 2 MORESESSION_SUMMARIZED

Shipped

9/29/2026, 2:29:25 PM

Click a lifecycle step above to view its details.

03Sludge Pulse
stack72 assigned stack729/29/2026, 12:04:39 AM

Sign in to post a ripple.