Skip to main content
← Back to list
01Issue
FeatureClosedSwamp CLIPublic
Assigneesskunk-ape

Relationships

#2605 CI review-integrity: record its verdict through @swamp/review-record instead of the text marker

Opened by skunk-ape · 9/28/2026

Follow-up to swamp-club #2587. The pre-PR reviews in verify-reviews now record their result through the repo-local @swamp/review-record model (submit validates a schema, decide gates the step), so no prose is parsed. CI's review-integrity job in .forgejo/workflows/ci.yml still decides its review with scripts/check_review_verdict.ts, which requires the verdict marker on the opening line and is prone to the same false failures. Move it to the record once #2587 is on main: CI takes its scripts from the base commit, so this cannot land in the same change. That job currently runs claude with no tools at all and from an empty directory, so granting it one scoped write and one submit command (and a swamp repo to submit into) is its own trust decision to make here. Also update .forgejo/prompts/review-integrity.md so its list of weakening changes names review_record.ts (e.g. making submit or decide accept a record it would previously have rejected). When nothing uses check_review_verdict.ts, remove it and its pin.

02Bog Flow
✓OPEN✓TRIAGED○IN PROGRESS◉CLOSED+ 1 MOREASSIGNEDCLASSIFICATION

Closed

9/28/2026, 7:28:36 PM

No activity in this phase yet.

03Sludge Pulse
skunk-ape assigned skunk-ape9/28/2026, 7:10:05 PM
Editable. Press Enter to edit.

skunk-ape commented 9/28/2026, 7:28:36 PM

Closing as not needed. CI does not run the verify reviews; review-integrity is a separate audit of trust-root changes that deliberately runs with no tools, from the base commit, as the independent check on the verification harness. No false failure of its first-line verdict gate has been observed, and the #2587 cause (a reviewer narrating a denied test command) does not apply to a tool-less agent. Moving it onto @swamp/review-record would add a swamp install and agent tools to the most sensitive CI job for no observed benefit. The auditor already covers extensions/models/ (including review_record.ts) under its weakened-criteria and pipeline-tampering checks. Two stale descriptions in .forgejo/prompts/review-integrity.md (check_review_verdict.ts as the review decider; extensions/models/ as only the issue-lifecycle model) can be refreshed in the next harness change.

Sign in to post a ripple.