Relationships
#2696 check_upgrades path test fails an extension that has no manifest instead of skipping it as unpublished
Opened by skunk-ape · 9/29/2026· Shipped 9/30/2026
scripts/check_upgrades.ts pathTest() returns the error 'no manifest name, cannot pull it' when an extension directory has no manifest.yaml, before it reaches the 'not published before this change, path test skipped' branch. An extension with no manifest at all has never been published, so it should be skipped like one whose manifest is new at this change. The module comment (line 33) and agent-constraints/verification-conventions.md both say the dynamic check is skipped for unpublished extensions.
Impact: gatorwalk-factory deliberately has no manifest.yaml until go-live (no_manifest_test.ts enforces it), so any model version bump in gatorwalk-factory fails verify-build. Found while working on swamp-club #2687, which reverted its work-item version bump to avoid this.
Repro: bump the version of gatorwalk-factory/extensions/models/work_item.ts with a matching upgrades entry, commit, then run: deno run --allow-read --allow-write --allow-env --allow-run scripts/check_upgrades.ts --base origin/main --path-test. The static check passes and the path test errors 'gatorwalk-factory: no manifest name, cannot pull it'.
Likely fix: in pathTest, when there is no manifest (or no name) at HEAD and none at the merge base, log the skip and return null; keep the error only for a manifest that exists without a name.
Shipped
Click a lifecycle step above to view its details.
Sign in to post a ripple.