Relationships
↔ sibling #3021#3020 extension push: testing-completeness warns once per generated model (262 warnings in 25 extensions) with no way to mark a package generated
Opened by skunk-ape · 10/5/2026· Shipped 10/6/2026
Problem
The testing-completeness review rule (src/domain/extensions/extension_review_rules.ts:192) checks for a sibling _test.ts per model file and warns once per model. On the swamp-extensions corpus that is 262 warnings across 25 extensions, 100% of generated models, which by design have no sibling test. In a generated package it drowns the one warning that matters.
Expected
- The rule reports once per extension ("N of M models have no sibling test"), not once per model.
- A
generated: truemanifest flag, or a codegen header in the file, silences it for that package or file. - The warning text says which flag silences it.
Acceptance
push --dry-runon a 25-model generated extension emits at most one testing-completeness warning, and none withgenerated: true.- A hand-written extension with one untested model still warns, once.
Out of scope
Per-rule suppression with a reason is a separate issue in the same lane and goes after this one.
Source: the extension push assessment (2026-10-02, swamp 20261002.194016) and the Extension Push UX Plan, which groups this with its lane and order.
Shipped
Click a lifecycle step above to view its details.
system commented 10/5/2026, 2:28:49 PM
Classified automatically when this issue was filed.
- Type: Feature
If you feel this classification is incorrect, add a ripple to tell us so.
skunk-ape commented 10/5/2026, 2:34:55 PM
Guardrail: the generated flag silences the testing-completeness rule only. It must not affect safety, dependency-trust, dynamic-code or credentials rules, and the push summary should say the package is marked generated.
Sign in to post a ripple.