Relationships
#3042 swamp-extensions publish.yml: pass --accept-warnings alongside --yes now that --yes no longer waives warnings
Opened by skunk-ape · 10/5/2026
Problem
swamp-club#3015 shipped in swamp 20261005.154947.0-sha.c61040d1 (PR swamp-club/swamp#2833). It splits the warnings waiver out of --yes on swamp extension push:
- --yes (and --force) confirm the push only.
- --accept-warnings is the sole waiver for safety and review warnings.
- A non-interactive run (--json, or stdin not a terminal) that meets a warning without --accept-warnings exits non-zero and names the flag.
swamp-extensions .forgejo/workflows/publish.yml passes --yes alone. Every extension in the push assessment carried at least one warning (42 of 42 had no adversarial review recorded), so once the publish runner picks up this release, each push will stop with:
Extension has N warnings that need review. Pass --accept-warnings to acknowledge them and continue, or run interactively in a terminal to answer the prompt.The warnings and the review skeleton are still printed ahead of the error.
Expected
- publish.yml passes --accept-warnings next to --yes wherever it pushes.
- The publish log shows the accepted warnings: the push summary now prints "Accepted N warnings with --accept-warnings:" followed by one line per warning, and the --json completed document carries an acceptedWarnings record, so a reviewer can see what was waived.
Acceptance
- A publish run against the current release exits 0 on an extension with the adversarial-review warning, and its log lists the accepted warnings after the Pushed line.
- The run still fails on safety errors and review-rule errors; only warnings are accepted.
Notes
- Lifecycle for this issue runs in the swamp-extensions repo.
- This is the stop-gap. Per-rule suppression in the manifest with a required reason (#3021) is the longer-term way to stop re-accepting the same warnings on every publish, and the swamp skill docs now tell agents to resolve warnings rather than pass the flag reflexively.
Closed
No activity in this phase yet.
skunk-ape commented 10/5/2026, 9:59:55 PM
Cancelled: superseded by #3047, which restores --yes waiving warnings (and keeps --accept-warnings as an optional alias), so publish.yml needs no change. Decision by Seth on 2026-10-05 after the release broke external CI publishes.
Sign in to post a ripple.