Relationships
#3098 Docs: declared acceptances for extension push warnings (quality.yaml sidecar, swamp-quality-ignore comments, For next time report)
Opened by skunk-ape · 10/6/2026
What changed
swamp-club#3021 (with #3020 linked) adds declared acceptances for warning-level push findings: an inline comment on the finding's line or the line above, in the form swamp-quality-ignore : , and a quality.yaml sidecar beside manifest.yaml for extension-scoped findings (bare-specifiers), file-scoped IPv4 acceptances in .txt files, and the generated declaration (by, source, commit). Every finding now carries a rule id, a line and a remediation text. The push summary and --json carry declaredAcceptances and a For next time section with the paste-ready acceptance per unaccepted finding, and swamp extension quality lists findings and acceptances too. Error-level findings have no acceptance form; an invalid acceptance blocks the push and a stale one warns. --yes is unchanged.
Pages to update
- content/manual/how-to/extensions/create-and-publish.md, section Address review warnings: today it says warnings prompt and lists adding tests or a review report. Add the acceptance comment and sidecar forms, say the For next time block prints the exact text to paste, and that acceptances are reviewed with the code in the pull request.
- content/manual/reference/extensions/publishing.md: add the rule-id table for warning-level and error-level findings, the comment syntax and placement rules, the quality.yaml schema, and the new JSON fields (declaredAcceptances, forNextTime, per-finding acceptance and remediation, contentMetadata.acceptances).
- content/manual/reference/extensions/manifest.md: note that the sidecar is discovered beside the manifest and is never named in it, because most manifests are regenerated.
Source of truth
The swamp PR for #3021 updates the swamp skill's extension-publish references and design/primitives/extensions.md; mirror those once it merges.
Closed
No activity in this phase yet.
skunk-ape commented 10/6/2026, 10:58:13 PM
Done in swamp-club PR #1298 (https://github.com/swamp-club/swamp-club/pull/1298, merge f928fe38), which folded this issue into the #3071 manual update. Samples are real output from swamp 20261006.221608.0-sha.5c0c6532. Closing.
Sign in to post a ripple.