Ts Review Lenses

Three adversarial TypeScript code-review prompts ("lenses") for an independent reviewer in a @swamp/software-factory run. Distilled from failure modes that escaped green test suites during real development.

• Lens A (idiom) — idiomatic, with-the-grain TypeScript; domain-types-first; no transliteration from another language; no paradigm zealotry.
• Lens B (correctness vs reality) — boundary validation, fixtures grounded in the real wire, secret hygiene, subprocess/IO correctness.
• Lens C (architecture) — module boundaries, the purity seam, dependency direction, verified change confinement.

Run as three separate passes (IDIOM-/CORR-/ARCH- finding id prefixes keep them distinct). The lens files are transport-neutral review prose; the swamp + findings-JSON contract is appended at run time.

Use

Pull this extension, then feed a lens as the prompt input to @atalanta/external-reviewer's external-review-findings workflow (optional companion — not a hard dependency), one invocation per lens. The bundled ts-review-lenses skill prints the exact wiring. A factory wanting same-context review instead uses the lenses as dispatch-stage systemPrompts.

swamp extension pull @atalanta/ts-review-lenses
# then invoke the bundled `ts-review-lenses` skill

Rename lens A from 'taste' to 'idiom' (label, IDIOM- prefix, lens-a-idiom.md) — a defensible standard, not a subjective preference.