Skip to main content
← Back to list
01Issue
BugShippedSwamp CLIPublic
AssigneesNone

Relationships

≡ duplicate of #3230

#3201 check_upgrades.ts skips models in nested extensions/models/ directories (e.g. stagecraft's engine/ and tracker/)

Opened by skunk-ape · 10/8/2026· Shipped 10/11/2026

Problem

scripts/check_upgrades.ts selects model files with isModelFile, whose pattern is (^|/)extensions/models/[^/]+.ts. It only matches files directly under extensions/models/.

stagecraft keeps its model types one level deeper: extensions/models/engine/factory.ts, engine/work_item.ts, engine/studio.ts, tracker/builtin.ts and tracker/linear.ts, as its manifest lists them. A change that bumps one of those versions gets 'No model definitions changed; no upgrade path to check.' Neither the static check (last upgrades toVersion equals the version) nor the --path-test dynamic check runs for them.

Reproduce

On the swamp-club #3194 branch, which bumps @swamp/stagecraft/factory and work-item to 2026.10.08.1, run: deno run --allow-read --allow-write --allow-env --allow-run scripts/check_upgrades.ts --base origin/main --path-test. It prints 'No model definitions changed'.

Expected

The gate finds every model file a manifest lists under models:, or every non-test .ts under an extensions/models/ tree that exports a model. Bumped stagecraft models would then get both checks.

02Bog Flow
✓OPEN✓TRIAGED✓IN PROGRESS✓SHIPPEDLINKED+ 5 MOREPR_MERGED+ 1 MORESESSION_SUMMARIZED

Shipped

10/11/2026, 12:29:51 AM

Click a lifecycle step above to view its details.

03Sludge Pulse
stack72 linked duplicate of #323010/10/2026, 9:19:19 PM

Sign in to post a ripple.