Skip to main content
← Back to list
01Issue
BugShippedSwamp CLIPublic
Assigneeszack

Relationships

#3559 MockVaultProvider.get and delete throw synchronously instead of rejecting

Opened by zack · 10/16/2026· Shipped 10/16/2026

src/domain/vaults/mock_vault_provider.ts declares get(secretKey): Promise and delete(secretKey): Promise as non-async functions, and for a missing key each throws synchronously instead of returning a rejected promise. A caller that awaits the call sees no difference, but one that chains .catch() on the returned promise gets an uncaught synchronous throw instead. Every other built-in provider rejects. Found while triaging swamp-club#3557; unrelated to that work, so filed separately. Fix: return Promise.reject(...) or mark the methods async, and add a unit test that the missing-key path rejects rather than throws.

02Bog Flow
✓OPEN✓TRIAGED✓IN PROGRESS✓SHIPPED+ 1 MOREASSIGNED+ 5 MOREREVIEW+ 9 MOREPR_MERGED+ 2 MORESESSION_SUMMARIZED

Shipped

10/16/2026, 7:42:22 PM

Click a lifecycle step above to view its details.

03Sludge Pulse
zack assigned zack10/16/2026, 7:08:10 PM

Sign in to post a ripple.