Relationships
#3563 VaultService.requireExistenceProvider labels the vault instance name as its type
Opened by zack · 10/16/2026· Shipped 10/16/2026
Follow-up to swamp-club#3561. PR #3173 changed requireDeleteProvider, requireAnnotationProvider and requireRefreshHookProvider in src/domain/vaults/vault_service.ts to name the configured vault type via the private vaultTypeOf(vaultName) helper instead of provider.getName(). requireExistenceProvider, added by swamp-club#3557 (PR #3172), merged two minutes earlier and was not covered: on main it still throws Vault 'name' (type: provider.getName()) does not support existence checks (vault_service.ts line 470). For built-in providers getName() returns the instance name (ControlPlaneVaultProvider returns the reserved vault name and does not implement has, so it can reach this message), so the parenthetical shows the vault name instead of its type. Fix: use this.vaultTypeOf(vaultName) in that message, and add a test like the requireDeleteProvider one in vault_service_test.ts: register a per-run vaultTypeRegistry type whose provider lacks has and answers getName() with the instance name, call the existence check on a vault named erp, assert the exact message names the registered type, and invalidateType in finally.
Shipped
Click a lifecycle step above to view its details.
Sign in to post a ripple.