Relationships
#3795 forEachNameWithoutSecrets property test fails intermittently: an empty-string secret and an overlapping recorded value give different names
Opened by skunk-ape · 10/22/2026
Found while running the full suite for swamp-club#3662, on main at 5affb9d8 (the failing code is unchanged on that branch). It fails about one run in three.
Test: src/domain/workflows/for_each_name_property_test.ts, the property 'a sentinel and a recorded value of the same secret give the same name'.
fast-check output: seed -1318973576, path 88:0:0:14:30. Counterexample ["","ply","ply",0], shrunk 4 times. Got sensitive-0ply where sensitive-0sensitive-0 was expected.
It looks like the masking does not handle an empty secret value overlapping a non-empty one, so the name keeps part of the recorded value. That is either a real masking gap in forEachNameWithoutSecrets or an arbitrary that should exclude empty secrets. Either way the property test is non-deterministic in CI and in the scheduled flaky-test job.
Open
No activity in this phase yet.
Sign in to post a ripple.