Skip to main content
← Back to list
01Issue
BugShippedSwamp CLIPublic
Assigneesskunk-ape

Relationships

#3796 main fails type check: query_view_test.ts passes a namespace string where expressionQueryView now takes a NamespaceReader (semantic conflict between #3790 and #3785)

Opened by skunk-ape · 10/22/2026· Shipped 10/23/2026

On origin/main at 59f664bf, deno check fails, so verify-build fails on every branch cut from main:

TS2345 [ERROR]: Argument of type 'string' is not assignable to parameter of type 'NamespaceReader'. assertStrictEquals(expressionQueryView("infra").record(legacy), legacy); at src/infrastructure/cel/query_view_test.ts:272:44

The two most recent merges touching the CEL query view landed back to back: d94aa0c0 (swamp-club#3790, swamp PR 3312) added the test call with a namespace string, and 59f664bf (swamp-club#3785, swamp PR 3310) changed expressionQueryView to take a NamespaceReader. Each passed verification on its own base.

Found while verifying swamp-club#3662.

02Bog Flow
✓OPEN✓TRIAGED✓IN PROGRESS✓SHIPPED+ 1 MOREASSIGNED+ 2 MOREREVIEW+ 7 MOREISSUE_UNLINKED+ 2 MORESESSION_SUMMARIZED

Shipped

10/23/2026, 1:10:11 AM

Click a lifecycle step above to view its details.

03Sludge Pulse
skunk-ape assigned skunk-ape10/22/2026, 10:43:50 PM
Editable. Press Enter to edit.

skunk-ape commented 10/23/2026, 2:34:37 PM

Fixed upstream by PR #3313 (typed-secrets 4.4, swamp-club#3733), which updated query_view_test to the new NamespaceReader signature. Type check passes on main as of 8540c1e3. Closing.

Sign in to post a ripple.