Relationships
↔ sibling #4793#4813 test: three 'crash' tests check SQLite rollback, not crash recovery
Opened by stack72 · 11/16/2026· Shipped 11/17/2026
Found while fixing swamp-club#4793. sqlite_commit_store_crash_test, the compaction crash case in datastore_v3_compaction_test, and datastore_v3_outbox_test killWriter stand in for a crash with worker.terminate(). A terminated thread is not a killed process: the OS releases no locks or file handles, and hot-journal or WAL recovery after a kill never runs. What the tests prove is that an uncommitted transaction is invisible and rolled back. Their own comments disagree on whether a terminated Worker's SQLite lock is released (sqlite_commit_store_crash_test.ts:61 vs datastore_v3_compaction_test.ts:588-591). Rename them for what they test and run them in-process; real kill-recovery belongs in swamp-uat against the binary.
Shipped
Click a lifecycle step above to view its details.
Sign in to post a ripple.