Relationships
#4881 CLI: idempotent swamp-club requests don't retry a 503, 502, 504 or timeout, so one blip fails the push registry checks
Opened by swamp_lord · 11/18/2026
What happens
When swamp-club answers a request with a transient failure, the CLI gives up on the first attempt. The failures are a 503 (the API answers 503 + Retry-After when its database is busy), a 502/504, or a request that times out. fetchWithRateLimitRetry (src/infrastructure/http/rate_limit.ts), which every SwampClubClient request goes through, retries only 429.
The visible case is swamp extension push. fetchCollectives → whoami fails once, so the push's registry checks don't run. A dry run reports:
Error: Registry check "authentication" could not run: registry did not answer: Whoami request failed (HTTP 503)A real push refuses ("Try again when … is reachable"). On 2026-11-18 a swamp-uat run failed this way on a single 503 and a single 15s whoami timeout. The server-side cause is fixed (swamp-club #4872), but a brief 503 or timeout is something the client should absorb.
Expected
Idempotent requests (GET/HEAD) retry transient failures a bounded number of times before reporting: 502/503/504 (honouring Retry-After, capped) and per-attempt timeouts and dropped connections. Non-idempotent requests (POST/PUT/DELETE) are not retried. The final error is the one the last attempt produced, so the messages users see don't change.
Scope
fetchWithRateLimitRetry, or a sibling it composes with, covers these failures for GET/HEAD, with backoff, jitter and the existing abortableSleep. The caller's signal cancels waits.- A retry is logged as a warning, as the 429 path already does.
- No change to POSTs, including
extensions/confirm.
Open
No activity in this phase yet.
swamp_lord commented 11/18/2026, 9:28:58 PM
Verification attestation posted for 4791092c (id 0b4a9fc3-b32f-482b-9938-1c862c258730): verify-build 5d5520f4, verify-reviews 211ac316 and verify-skills 81f3b9ea all passed (gate allPassed). The reviews drove three fixes: startup scope resolution asks whoami once (retry: false), deadline errors report the real elapsed time, and no test sleeps through real backoff. Posted with issue-lifecycle's own client after the same AttestationSchema check, because the ops lifecycle model (2026.08.16.1) has no post_attestation.
swamp_lord commented 11/18/2026, 9:37:06 PM
Shipped in swamp 20261118.213125.0-sha.baa5d963 (PR #3859, merge baa5d9634): https://github.com/swamp-club/swamp/releases/tag/v20261118.213125.0-sha.baa5d963
Sign in to post a ripple.