Relationships
#4846 Flaky test: webhook held delivery to a starting leader counts a third forward under load
Opened by zack · 11/17/2026· Shipped 11/17/2026
src/serve/webhook_test.ts, test 'handleRequest: a held delivery is sent to a starting leader no faster than its Retry-After' (added in swamp-club#4811), failed in a verify-build run under full-suite load: expected 2 forwards, got 3. It passes when the file runs alone. The test relies on real wall-clock time (a 503 with retry-after 4 inside an 8 s hold), so a delayed timer under load lets a third try land before the hold ends. Seen in verify-build run d0e3692b-f9a1-4002-a72a-76dd31ae48a7 for commit 28924bfa7 (unrelated change, swamp-club#4836). Likely fix: drive the hold and retry timers from an injected clock, or assert on work done rather than elapsed time, per the timing rules in AGENTS.md.
Shipped
Click a lifecycle step above to view its details.
Sign in to post a ripple.