Relationships
#4948 extension push: content hash still depends on the extension's folder with paths.base: manifest (review report reported missing)
Opened by vcjdeboer · 11/20/2026
Problem
swamp extension push computes a different content hash (and so a different adversarial-review report path) for byte-identical extension sources depending on which folder of the swamp repo the extension sits in. A review recorded for one checkout (e.g. a git worktree) is then reported as missing (adversarial-review-report) when pushing the same commit from another folder.
The manifest uses paths: base: manifest, so after #3100 (shipped) the file names and hash input should be relative to the manifest directory (see also #3142). The push summary still labels files relative to the repo dir, e.g. publish_1/quarto-deck/README.md and .claude/worktrees/qd-base/README.md.
Steps to reproduce
- A swamp repo with an extension whose
manifest.yamlhaspaths: base: manifest, registered in.swamp-sources.yaml(herepublish_1/quarto-deck,@vcjdeboer/quarto-deck2026.11.20.2). - Put the same commit in three folders inside the repo: the source folder, a git worktree under
.claude/worktrees/qd-base, and a freshgit archive HEADexport inpublish_1/qd-hashtest. Tracked files are identical (git ls-files -sequal). - For each:
swamp extension push <folder>/manifest.yaml --dry-run --jsonand readcontentHash.
Actual
.claude/worktrees/qd-base→[REDACTED-SECRET-1]publish_1/quarto-deck→[REDACTED-SECRET-2]publish_1/qd-hashtest→[REDACTED-SECRET-3]
Adding an untracked file outside the manifest's lists (e.g. uat/scratch.txt) does not change the hash, so the folder location appears to be the only difference. A report written for the worktree hash was reported missing when the push ran from publish_1/quarto-deck.
Expected
The same extension content gives the same contentHash and review-report path wherever it sits, as #3100 describes for paths.base: manifest.
Environment
- swamp 20261120.092442.0-sha.82005b8c
- macOS (Darwin 27.2.0, arm64)
- Review dir: default (
/var/folders/.../T/swamp-extension-review/),SWAMP_EXTENSION_REVIEW_DIRnot set
In Progress
Click a lifecycle step above to view its details.
vcjdeboer commented 11/20/2026, 4:09:46 PM
The issue body's three content hashes were redacted as secrets on submit. First 8 hex characters of each, so the difference is visible: .claude/worktrees/qd-base → 69821a6e…, publish_1/quarto-deck → 87e58d52…, publish_1/qd-hashtest → f252a00a… (same commit, identical tracked files).
Sign in to post a ripple.