Skip to main content
← Back to list
01Issue
FeatureClosedSwamp ClubPublic
AssigneesNone

Relationships

#3026 Docs: extension push --accept-warnings is separate from --yes (manual pages)

Opened by skunk-ape · 10/5/2026

What changed

swamp-club#3015 splits the warnings waiver out of --yes on swamp extension push:

  • --yes (and --force) confirm the push only. They no longer waive safety or review warnings.
  • A new --accept-warnings flag is the only waiver. The dry-run and push summaries (log and --json) carry an acceptedWarnings record listing the safety and review warnings that were accepted; the field is omitted when nothing was accepted.
  • A non-interactive run (--json, or stdin not a terminal) that hits a safety or review warning without --accept-warnings exits non-zero with an error naming --accept-warnings. The warnings (including the review skeleton) are still printed before the error.
  • Interactive behaviour is unchanged: two prompts, two answers. Dry-run exits non-zero exactly when the real run would, and never prompts.

Manual pages that describe the old behaviour

content/manual/reference/extensions/publishing.md

  • Flag table: -y, --yes says Skip confirmation prompts. It now confirms the push only. Add a row for --accept-warnings.
  • Safety warnings and Review warnings sections: say the push prompts for confirmation. Add that non-interactive runs refuse without --accept-warnings and name the flag, and that the dry_run and completed JSON objects carry acceptedWarnings when the flag was used.
  • JSON output section: note the new acceptedWarnings field on the final object.

content/manual/how-to/extensions/create-and-publish.md

  • Address review warnings: the dry-run --json recipe used to obtain the review skeleton now exits non-zero while the adversarial-review-report warning stands (the UAT runner, CI and coding agents have no terminal). The skeleton is still in the output. Say so, and say the fix is to write the report, not to pass --accept-warnings.
  • Publish to the registry: mention that CI publishes need --accept-warnings alongside --yes only for warnings the team has reviewed and chosen to accept.
02Bog Flow
✓OPEN○TRIAGED○IN PROGRESS◉CLOSED

Closed

10/6/2026, 1:37:27 AM

No activity in this phase yet.

03Sludge Pulse
Editable. Press Enter to edit.

stack72 commented 10/6/2026, 1:37:26 AM

The PR wsa reverted here

stack72 commented 10/6/2026, 1:49:46 AM

Closing without a docs change: swamp-club#3015 (the --accept-warnings split from --yes on swamp extension push) was reverted. The manual never documented --accept-warnings, and the released extension push --yes behaves as content/manual/reference/extensions/publishing.md already describes. Noted in https://github.com/swamp-club/swamp-club/pull/1294, which covers the other docs issues from this batch.

Sign in to post a ripple.