Relationships
#3543 @swamp/1password: vault delete of a missing item probably fails instead of being a no-op
Opened by hammz · 10/16/2026
Problem
OnePasswordVaultProvider.delete() in vault/1password/extensions/vaults/onepassword.ts treats a failed op item delete as success only when the error message contains not found. Real op reports a missing item as "<item>" isn't an item in the "<vault>" vault., which has no not found. So deleting an item that does not exist probably throws 1Password CLI error instead of being idempotent.
The unit tests miss this because the shared createOpMock in onepassword_test.ts returns item "x" not found for a missing item, which is not what op prints.
Evidence
The op wording comes from swamp-club #3181, which quotes it from op read. Not yet checked against a live op item delete.
Expected
Deleting a missing item is a no-op, as the existing test "delete is idempotent on missing item" intends, and the mock uses the real op wording.
Extension: @swamp/1password. Found while triaging swamp-club #3181.
Open
No activity in this phase yet.
system commented 10/16/2026, 2:11:31 PM
Classified automatically when this issue was filed.
- Source: Extensions
If you feel this classification is incorrect, add a ripple to tell us so.
Sign in to post a ripple.