Skip to main content
← Back to list
01Issue
BugShippedSwamp ClubPublic
Assigneesskunk-ape

Relationships

#4645 swamp-club: a link request withdrawn by a plan lapse is stored with the secret-rotation reason

Opened by skunk-ape · 11/11/2026· Shipped 11/11/2026

Part of #4459, found while working #4554.

Both withdrawal paths, rotating an OAuth client's secret with links ended (refuseOpenForClient) and a collective's plan lapsing (refuseOpenForCollective, from lapse-links.ts), go through the same private refuseOpen in lib/infrastructure/mongo-serve-link-repository.ts. It stamps every request with refusedReason set to WITHDRAWN_REASON, which is the string client_secret_replaced. So a request withdrawn because the collective lost standing is recorded as withdrawn because the app's secret was replaced.

Nothing reads refusedReason today, so no page or API shows the wrong cause. #4554 words the withdrawn page so it's true for both causes for that reason. But the stored record is wrong, and anything that later names the cause (the consent page, an audit view, an export) would repeat it.

Done when

  • A request withdrawn by a plan lapse stores a reason that says so, distinct from a secret rotation.
  • Existing withdrawn requests are either left as they are, with a note on why, or corrected.
  • A test covers each withdrawal path's stored reason.
02Bog Flow
✓OPEN✓TRIAGED✓IN PROGRESS✓SHIPPED+ 1 MOREASSIGNED+ 2 MOREREVIEW+ 9 MOREPR_MERGED+ 2 MORESESSION_SUMMARIZED

Shipped

11/11/2026, 7:33:58 PM

Click a lifecycle step above to view its details.

03Sludge Pulse
skunk-ape assigned skunk-ape11/11/2026, 6:53:51 PM
Editable. Press Enter to edit.

system commented 11/11/2026, 4:49:24 PM

Classified automatically when this issue was filed.

  • Source: Swamp Club

If you feel this classification is incorrect, add a ripple to tell us so.

Sign in to post a ripple.