Skip to main content
← Back to list
01Issue
BugClosedSwamp CLIPublic
AssigneesNone

Relationships

#2546 verify-reviews depends on an implicitly auto-installed @swamp/git; a broken local install fails the run with an opaque error

Opened by stack72 · 9/25/2026

verify-reviews gets @swamp/git (its change-detection steps, modelType: "@swamp/git") by implicit auto-install from the host repo's extension state. The workflow has no step that pulls or checks the extension. A broken or stale local install fails the whole run at the diff step with an error that doesn't point at the environment, before any review runs.

Observed

On commit 41b980916 (branch fix/2336-ssh-sudo-chained), verify-reviews failed in 14s:

detect-changes │ failed diff
system │ Unknown model type: [@swamp](/u/swamp)/git
Steps: 2 passed · 1 failed · 1 skipped   (checkout ✓, diff ✗, changed-files ○, remove-worktree ✓)

The underlying cause was a swamp core catalog problem (filed separately): the @swamp/git files were on disk but not registered. Auto-install refused because the files already existed. The harness surfaced this only as a failed gate step.

verify-build ran at the same time and passed. It doesn't use @swamp/git, so only the reviews half of the loop is exposed.

Why it matters

  • Failing closed is correct: no review ran, so the gate shouldn't pass.
  • But the verification loop is the only build/review gate before a PR, and its dependency on a registry extension is implicit. How healthy the host's .swamp/ is decides whether verification works at all. The agent following verification.md treats a failure as something to fix in code, and the failure text gives no hint that it's an environment problem.

Expected (any of)

  • A setup step in verify-reviews that installs @swamp/git explicitly at a pinned version (for example swamp extension pull @swamp/git@<version> --force) before detect-changes, so the run doesn't depend on whatever is in the host's catalog.
  • Or a preflight that resolves @swamp/git and fails with an environment error naming the repair command.
  • And a "Handling Failures" entry in agent-constraints/verification-conventions.md for missing model types, saying it's an environment failure and how to repair it.
02Bog Flow
✓OPEN○TRIAGED○IN PROGRESS◉CLOSED

Closed

9/25/2026, 7:26:02 PM

No activity in this phase yet.

03Sludge Pulse

Sign in to post a ripple.