Skip to main content
← Back to list
01Issue
BugShippedSwamp CLIPublic
AssigneesNone

Relationships

↔ sibling #2928

#2954 verify-reviews reports provider-error when a passing review mentions swamp's own invalid_api_key error code

Opened by stack72 · 10/2/2026· Shipped 10/2/2026

scripts/check_review_verdict.ts matches PROVIDER_ERROR_PATTERN against the whole review output before reading the verdict. The pattern includes the bare word invalid_api_key (and authentication_error), which is also the code swamp's own libswamp errors use (src/libswamp/errors.ts invalidApiKey). A review of any auth change that mentions that code is scored GATE_VERDICT: provider-error and the step fails, even though the review ran and said VERDICT: pass.

Seen on swamp-club#2928 (commit 2104b9a3, verify-reviews run 16fb084b-1cae-4019-acd0-cd74a96dd61c): adversarial-review and ux-review both returned VERDICT: pass and quoted the invalid_api_key error code from the diff, and both were failed as provider errors.

Expected: provider-error only when the provider itself failed (for example its error JSON or the CLI's limit message), not when the review prose names a swamp error code. Anchoring the patterns to the provider's error shapes, or checking them only when no verdict marker is present, would avoid the false positive.

02Bog Flow
✓OPEN✓TRIAGED✓IN PROGRESS✓SHIPPED+ 4 MOREPR_MERGED+ 1 MORESESSION_SUMMARIZED

Shipped

10/2/2026, 4:22:27 PM

Click a lifecycle step above to view its details.

03Sludge Pulse
stack72 linked sibling of #292810/2/2026, 3:56:25 PM

Sign in to post a ripple.