Relationships
#3718 extension quality names the wrong cause: a bundle failure prints no reason, the not-audited row always blames an outage, and symbols-docs blames JSDoc when deno doc failed
Opened by skunk-ape · 10/21/2026· Shipped 10/22/2026
Summary
In three places, swamp extension quality names the wrong cause or hides it, so the author is told to fix the wrong thing. The #3682 session found all three while capturing swamp-club docs.
1. A bundle failure prints no reason
extension quality prints only "Bundle compilation failed. Fix the errors above and try again.", and nothing is above it. extension push --dry-run on the same extension shows the deno error. The push command renders details.compilationErrors (src/cli/commands/extension_push.ts:614), but the quality path (src/libswamp/extensions/quality.ts, where prepare errors are yielded as {kind: "error"}) never renders them.
Expected: quality shows the same compilation errors as push.
2. The not-audited summary always blames an outage
When a dependency is not audited because no published version matches its specifier, the finding's own fix correctly says "Change the specifier to a version the registry publishes." (NOT_AUDITED_FIX.specifier in extension_dependency_trust_checker.ts). The dependency-trust row's remediation in extension_rubric_scorer.ts dependencyTrustRow always says the dependencies were "not audited because an OSV, npm or JSR lookup failed. Re-run when all three are reachable."
Expected: the row's text follows the findings' causes, and says to re-run only when every unaudited finding was an outage.
3. symbols-docs blames JSDoc when deno doc failed
When deno doc fails, scoreFromFactors sets the documented ratio to 0 (docFailed), and symbolsRow then says "Add JSDoc to ≥…% of exported symbols (current: 0%)", even when the source is fully documented.
Expected: when the doc analysis failed, the symbols-docs remediation names that failure and its error, not missing JSDoc. The same holds for has-readme ("Has README or module doc"), which asks for a module-level JSDoc when there is no README. (Triage: the rubric has no entrypoint-docs factor; has-readme is the row that carries the module-doc half.)
Notes
- Triage checked the swamp-club registry scorer (origin/main e9cb7eeb):
lib/domain/scorecard/score.tsproduces no remediation text, and the scorecard UI showsdocAnalysisErroras its own banner and lists dependency-trust details without a re-run or JSDoc sentence, so it does not share 2 or 3 and needs no swamp-club issue. - Docs: the swamp-club manual should change once this ships (follow #3631).
Shipped
Click a lifecycle step above to view its details.
Sign in to post a ripple.