← Back to list
01Issue
BugOpenExtensionsPublic
AssigneesNone
Relationships
#4124 @swamp/video/brand: follow-ups from the initial review (render hang, odd sizes, Chromium errors)
Opened by skunk-ape · 10/29/2026
Non-blocking findings from the verify-reviews run on the initial @swamp/video/brand PR (swamp-club #4104, commit 8a6d98e67):
- medium: scene.ts waits for Chromium's page-load event with no timeout and nothing watching the socket close; if the browser dies after accepting the page but before it loads, cards or stage never returns, and cancelling the run does not reach that wait.
- low: the 16:9 check rounds, so an odd size such as 1919x1079 passes and the H.264 encode fails only after every frame is captured; require even width and height up front.
- low: Chromium's stderr is discarded, so a failed launch shows only a generic 15s DevTools timeout; keep its tail for the error.
- low: a very long campaignUrl past QR capacity (about 2.3 KB) surfaces the QR library's error without naming campaignUrl.
- low: with a 1s intro the thumbnail still is taken at t=0, while the intro is still black.
- low (core @swamp/video): every .webm overlay is forced through the libvpx-vp9 decoder, so VP8 WebM overlays in custom cards will not decode.
02Bog Flow
Open
No activity in this phase yet.
03Sludge Pulse
Editable. Press Enter to edit.
system commented 10/29/2026, 6:04:19 PM
Classified automatically when this issue was filed.
- Type: Bug
- Source: Extensions
If you feel this classification is incorrect, add a ripple to tell us so.
Sign in to post a ripple.