Relationships
#4163 build-swamp-extension example: code-review isn't given the quality evidence, so the reviewer reports quality as missing
Opened by mellens · 10/30/2026
What happens
In the shipped example references/examples/build-swamp-extension.yaml (@swamp/stagecraft 2026.10.26.2), the code-review stage gives the reviewer only three products:
context:
inject: [plan, change-summary, checks]The check stage records swamp extension quality --json as separate evidence, quality. Code review never receives it, so the reviewer can't see:
- whether quality was run;
- what it scored;
- whether a person waived it (
quality-waiver).
Seen in a run
One work item on this factory, "Add a shout method". The plan's testing strategy named swamp extension quality manifest.yaml.
- At
check, quality was run and recorded: grade D, 43%,allPassed: false. - A person approved
quality-waiver, and the item tookpassed-with-quality-waivertocode-review. - The code reviewer, sent the dispatch prompt unchanged, reported a medium finding: the recorded checks don't include quality, which the plan's testing strategy names.
The finding was false. Quality had run, and its result and the waiver were both recorded. The reviewer just wasn't given either.
Expected
The code reviewer sees the quality result, and that it was waived, so it can judge the change against them and doesn't report quality as missing.
Suggested fix
Add quality to the inject list:
inject: [plan, change-summary, checks, quality]The code-review prompt could also say that a waived quality score is a person's decision and is not a finding. starter.yaml may have the same gap if it records quality the same way.
Upstream repository: https://github.com/swamp-club/swamp-extensions
Environment
- Extension:
@swamp/stagecraft@2026.10.26.2 - swamp:
20261029.225317.0-sha.d1cc2a16 - OS:
darwin(aarch64) - Deno:
2.9.8 - Shell:
/bin/zsh
Open
No activity in this phase yet.
system commented 10/30/2026, 11:55:43 AM
Classified automatically when this issue was filed.
- Source: Extensions
If you feel this classification is incorrect, add a ripple to tell us so.
Sign in to post a ripple.