Relationships
#4400 On Windows, withIndexQueue warns when the run index lock file cannot be made, where the test expects it silent
Opened by zack · 11/4/2026
src/infrastructure/persistence/workflow_run_index_test.ts:385 (withIndexQueue: runs the function unlocked, without a warning, where the lock file cannot be made) has failed on 10 of the 11 Windows Compatibility runs since it landed on 2026-11-03 00:14Z (latest https://github.com/swamp-club/swamp/actions/runs/41864132261, dd6591148).
The test expects no warnings, but gets:
"Changing the run index of C:\Users\[REDACTED]\AppData\Local\Temp\…\not-a-directory\runs without its lock, so a change another process makes to it meanwhile may be lost until the index is next repaired: …"The test puts the runs directory under a plain file, so the lock file cannot be created. The code then runs unlocked and stays silent only for the error kind it expects. On POSIX that is NotADirectory, while Windows reports a different error (likely NotFound or os error 3, "path not found"), so the code takes the warning branch. Added in fb59d8906 (swamp-club#4235, swamp-club#4224). Either the silent case must recognize the Windows error kind, or the test's expectation is POSIX-specific.
In Progress
Click a lifecycle step above to view its details.
Sign in to post a ripple.