← Back to list
01Issue
FeatureShippedExtensionsPublic
Assigneesstack72
Relationships
#4458 @swamp/cve/sshole follow-ups: backport detection, file-read access rules, sshd.pam, Include, docker run timeout
Opened by stack72 · 11/5/2026· Shipped 11/5/2026
Non-blocking findings from the verification reviews of the new @swamp/cve/sshole extension (#4452, PR #660), left for a follow-up.
Verdict accuracy
- Non-Alpine musl builds rated vulnerable from the version alone (analysis.ts patchState). OpenWrt, buildroot and source builds below 10.6p2 get a firm vulnerable, although a vendor backport that keeps the upstream version cannot be detected. Consider unknown for non-Alpine musl below 10.6p2, or a per-vendor tracker like the Alpine one.
- File-read config ignores AllowUsers/DenyUsers/AllowGroups/DenyGroups (analysis.ts parseProbe). When sshd -T is unavailable the access rules are not read at all, so '*' accounts are not marked as assumed and nothing is recorded under notChecked. This only over-reports exposure; record it, and mark the accounts as assumed.
- A running sshd.pam is reported as in doubt (analysis.ts pamBuildInDoubt). The probe already sees SSHD_RUNNING=pam; resolve it as the PAM path (probe sshd.pam itself: ldd, sshd -T) rather than leaving the verdict unknown.
- Match detection misses Include outside sshd_config.d (probe.ts). Only /etc/ssh/sshd_config and sshd_config.d/*.conf are searched for Match lines; follow any Include path.
Robustness
- docker run timeout can leave the scan container running (transport.ts startDockerImage). If docker run exceeds 120s (slow pull), the CLI is killed and docker rm -f runs at once, but the daemon may still create and start the container, which then lives up to an hour (sleep 3600, --rm). Pull the image first with its own timeout, or retry the removal after docker wait.
- No direct tests for transport.ts (runArgv timeout handling, startDockerImage cleanup on failure). Add tests that stub the docker command.
02Bog Flow
Shipped
Click a lifecycle step above to view its details.
03Sludge Pulse
Editable. Press Enter to edit.
system commented 11/5/2026, 10:00:25 PM
Classified automatically when this issue was filed.
- Source: Extensions
If you feel this classification is incorrect, add a ripple to tell us so.
Sign in to post a ripple.