Skip to main content
← Back to list
01Issue
BugClosedExtensionsPublic
AssigneesNone

Relationships

#4463 @swamp/cve/tailworm: follow-ups from #4456 review (TS_SSH_DISABLE_FORWARDING edge cases, raised fixedVersion text)

Opened by stack72 · 11/5/2026

Low findings from the verify-reviews runs on PR #661 (swamp-club #4456), shipped as known limitations.

  1. The probe reads TS_SSH_DISABLE_FORWARDING only from tailscaled.service; the mitigate drop-in goes to whatever unit the cgroup names (for example tailscaled@x.service), so a pending-restart value on a templated unit is not detected.
  2. systemd gives EnvironmentFile= priority over Environment=. If /etc/default/tailscaled sets TS_SSH_DISABLE_FORWARDING=0, the 51-tailworm-ssh-forwarding.conf drop-in has no effect; the rescan reports it correctly as open, but no note says why. Add a note when the defaults file has a value that is not true.
  3. After a restart step that failed with an ordinary error (not exit 255, for example unit not found), mitigate still polls tailscaled for up to 30s (longer on a dropped transport). Only wait when the restart succeeded or exited 255.
  4. advisory.fixedFindings and unfixedFindings put the module constants straight into each result; copy them.
  5. With fixedVersion raised above 1.104.4, a 1.104.4 host with nothing exposed gets No action required instead of an upgrade line to the required release. Also check tailscale.patched.
  6. For an unconfirmed TS_SSH_DISABLE_FORWARDING, the recommendation still says to set it and restart; give a separate message (scan as root to confirm).
  7. The running-knob SSH detail, the finding-11 recommendation and the headscale recommendation hard-code until Tailscale 1.104.4 and ignore a raised fixedVersion.

Upstream repository: https://github.com/swamp-club/swamp-extensions

Environment

  • Extension: @swamp/cve/tailworm@2026.11.05.1
  • swamp: 20261103.194535.0-sha.01cbe5cd
  • OS: darwin (aarch64)
  • Deno: 2.9.8
  • Shell: /bin/zsh
02Bog Flow
✓OPEN○TRIAGED○IN PROGRESS◉CLOSED

Closed

11/5/2026, 10:32:55 PM

No activity in this phase yet.

03Sludge Pulse
Editable. Press Enter to edit.

system commented 11/5/2026, 10:32:14 PM

Classified automatically when this issue was filed.

  • Source: Extensions

If you feel this classification is incorrect, add a ripple to tell us so.

Sign in to post a ripple.