← Back to list
01Issue
BugShippedSwamp CLIPublic
Assigneeszack
Relationships
#4481 repo prune follow-ups: report failed writes apart from skips, resolved path in errors, upgrade note indent, matcher tests
Opened by zack · 11/6/2026· Shipped 11/6/2026
What
Non-blocking review suggestions left over from the verification of #4447 (PR swamp-club/swamp#3646, swamp repo prune).
- A failed write is reported as a skip and exits 0.
ToolSettingsPruner.apply(src/domain/repo/tool_settings_pruner.ts) records a file it cannot write or delete inskippedwith the reason "it could not be changed: ...", and the command succeeds. A--jsonconsumer cannot tell a deliberate skip (symlink, outside the repo) from a failed write without matching prose. Report failures in their ownfailedarray and exit non-zero when any change failed. - The not-a-repo error shows the raw path argument.
notARepository(input.path)insrc/libswamp/repo/prune.tsprints "Not a swamp repository: .. Run 'swamp repo init' first." when no path is given. Use the resolvedrepoPath.value, asrepo upgradedoes. - The leftover note's indentation. In
LogRepoUpgradeRenderer(src/presentation/renderers/repo_init.ts),leftoverSettingsLinesis written with a two-space indent even when no "Tools: [...] -> [...]" line is above it. Other top-level warnings in that renderer start at column 0. - No unit test for
src/domain/repo/audit_hook_command.ts. Its matchers moved out ofrepo_service.tsand are now exported. Pin the binary spellings on their own: quoted.exe, absolute path, trailing text rejected, and the claude optional--tool claudesuffix. - Smaller items:
- A hook event key named
__proto__is dropped when hooks are rebuilt on a plain object inpruneClaudeSettings/flatHooksRule; build withObject.fromEntriesor a null-prototype object. repoInithas only a failure-path test forprunableSettings; add the success path, asrepoUpgradehas.- I/O failures in
repoPrunesurface asvalidationFailed; a more accurate error kind would help JSON consumers.
- A hook event key named
02Bog Flow
Shipped
Click a lifecycle step above to view its details.
03Sludge Pulse
Editable. Press Enter to edit.
system commented 11/6/2026, 4:35:59 PM
Classified automatically when this issue was filed.
- Type: Bug
If you feel this classification is incorrect, add a ripple to tell us so.
Sign in to post a ripple.