Relationships
#4514 issue-lifecycle: code conformance review is the final gate before the PR, after verification
Opened by stack72 · 11/8/2026· Shipped 11/8/2026
Problem
The issue lifecycle runs the code conformance review before verification. Verification can fail and send the lifecycle back to implementing, where fixes are made in response to build failures and review findings. Those fixes are never compared against the approved plan: the conformance review is bound only to the plan version, and the conformance-review-required check on verify only checks that a review exists. Code reaches a PR without a conformance review of what actually ships.
Governance model wanted
agree a plan -> adversarial review of the plan -> implement -> verify (and fix until it passes) -> code conformance review of the verified code -> attestation -> PR.
Proposed change
- code_conformance_review and justify_deviations run in the verifying phase, after verification_passed, and no longer in implementing.
- code_conformance_review requires a passing verification result and records its commit on the review.
- code-conformance-clear gates post_attestation, link_pr and complete, and requires the review commit to equal the verified commit. link_pr is blocked if no conformance review has been run for the verified commit.
- complete can no longer close straight from implementing; an ad-hoc close goes through verify, verification_passed and conformance first (complete allowed from verifying).
- The conformance-review-required check on verify is removed; it only existed because conformance could not be recorded in verifying.
- Conformance that finds code to change goes back through verification_failed -> implementing -> verify -> conformance. Justifying a deviation does not change code and does not send the lifecycle back.
- fast_forward stops writing a conformance review; ad-hoc work runs conformance after verification like everything else.
- The issue-lifecycle skill (SKILL.md, implementation.md, verification.md, code-conformance-review.md) is rewritten to the new order.
Shipped
Click a lifecycle step above to view its details.
Sign in to post a ripple.