Relationships
#4550 serve: reload installs webhook entries from serve.yaml without validating them
Opened by zack · 11/9/2026· Shipped 11/9/2026
Problem
A reload (SIGHUP or swamp serve reload) reads serve.yaml through readServeConfigFile in src/serve/serve_config.ts, which parses the YAML and casts it to ServeConfigFile without running validateServeConfig or validateWebhookEntry. performServeReload (src/serve/extension_reload.ts) then hands config.webhooks to the webhook updater, which calls parseWebhookConfig and WebhookService.updateEndpoints. None of these check the entry.
So the checks boot and swamp serve check-config apply to a webhook entry (route present and starting with a slash, workflow and secret present, scheme known, generic scheme has a header) are skipped on reload. A config that serve would refuse at boot can be installed by a reload, and a malformed entry fails later in a less clear way (for example resolveSecret on a missing secret) or installs a verifier with an unknown scheme.
Expected
A reload validates webhook entries exactly as boot does and, on a refusal, keeps the previous route table and reports the reason.
Notes
Found while triaging swamp-club#4407, which adds a route-shadowing check and enforces it in WebhookService so reload cannot bypass it. This issue covers the remaining entry checks, which are out of scope there.
Shipped
Click a lifecycle step above to view its details.
Sign in to post a ripple.