Relationships
#4573 autoDefinitions retention follow-ups: release failure misreports removals, step wording, quoted log list, lanes doc
Opened by stack72 · 11/10/2026· Shipped 11/10/2026
Follow-up from swamp-club#4299 (PR swamp-club/swamp#3703): non-blocking review notes accepted at ship time.
A failed lock release reports deletions that went through as a failure. In
src/libswamp/retention/auto_definitions.ts:219,collectBatchcallsreleaseAllafter its removals succeed. If a release throws (for example a transient S3/GCS error releasing a model lock), the batch rejects, so itsremovedandbytesReclaimedare lost.swamp run gcthen reports a failure for definitions it already removed, and the retention pass marks the kind incomplete. Fix: on the success path, log the release failure and return the batch result. The failure path (line 209) already logs instead of throwing. Add a test where a release fails after a successful removal and the batch still reports the removal.Workflow-step refusal wording.
src/domain/workflows/execution_service.ts:2405hard-codes "Behavior …" and says "was removed, or removed and created again". The direct and serve runs usedefinitionChangedUnderLockinsrc/libswamp/models/run.ts, whose noun follows the model/behavior surface. Make the step text read cleanly ("was removed, or replaced by a new definition with the same name") and match the surface wording, keeping thedefinition_changed_under_lockcode.The auto-definition list prints in quotes in log mode.
src/presentation/renderers/run_gc.ts(lines 70, 86, 176) interpolatesautoDefinitionList(...)into a LogTape template, so the list renders as"a (command/shell), b (command/shell)". Render it without the quotes (for example as one interpolated value per line, or a separate list line).Design doc: per-worker lane definitions.
design/surfaces/repo.md:311("Auto-definitions") notes that steps naming a behavior by expression are not protected by the literal-reference check. Per-worker lane definitions (perWorkerBehaviorName) are never named literally either, so only their data and outputs keep them. Add that to the same sentence.
Shipped
Click a lifecycle step above to view its details.
Sign in to post a ripple.