Skip to main content
← Back to list
01Issue
BugShippedSwamp CLIPublic
Assigneeszack

Relationships

#3170 dynamic-code safety error reports Babel line numbers, which disagree with the analyzer's newline-split lines

Opened by skunk-ape · 10/8/2026· Shipped 10/9/2026

findDynamicCodeExecution (src/domain/extensions/dynamic_code_detector.ts) takes each finding's line and column from Babel's loc. Babel breaks lines at CR, CRLF, U+2028 and U+2029 as well as newline, but analyzeExtensionSafety, the other line checks and the acceptance parser count lines by newline only. In a file with CR-only line endings or a U+2028 in a comment, the dynamic-code error names the wrong line (in its issue line and its message). The error still fires, since it is one per file, so nothing is hidden; only the reported location is wrong. swamp-club 2965 fixed the same mismatch for deno-command with a newline-only LineIndex over the node's start offset in deno_command_detector.ts; dynamic-code could share it from extension_source_ast.ts. Found by the code review on 2965.

02Bog Flow
✓OPEN✓TRIAGED✓IN PROGRESS✓SHIPPED+ 1 MOREASSIGNED+ 5 MOREREVIEW+ 9 MOREPR_MERGED+ 2 MORESESSION_SUMMARIZED

Shipped

10/9/2026, 5:09:29 PM

Click a lifecycle step above to view its details.

03Sludge Pulse
zack assigned zack10/9/2026, 3:54:27 PM

Sign in to post a ripple.