swamp extension push re-emits the adversarial-review-report reviewRuleWarnings entry — carrying a .file path — for a review that is present and content-hash-matching but whose only "problem" is that a dimension honestly recorded "verdict": "issue". The warning is emitted with the same ruleId and the same .file field used for the genuinely actionable "review missing / stale" case, so a downstream gate cannot tell the two states apart.

Concretely: a completed review with an issue verdict is reported identically to no review at all, and its remediation .file points at a file that already exists and is already correct — following the documented "write the report to .file" remediation can never clear it.

Environment

swamp 20260718.233837.0-sha.f5bb6b99 (macOS)
SWAMP_EXTENSION_REVIEW_DIR set to a committed .swamp-reviews/ dir
Extension: @jentz/aws-stackset-audit v2026.07.04.1

Repro

Have a committed, hash-matching adversarial review for an extension, all dimensions pass/na. Set SWAMP_EXTENSION_REVIEW_DIR to its directory.
Baseline: swamp extension push <manifest> --dry-run --json --yes → no adversarial-review-report warning; reviewRuleWarnings absent. (Gate clean.)
In that same committed review JSON, flip exactly one dimension from "verdict": "pass" to "verdict": "issue" (the file name / content hash is unchanged — the hash is over extension source + manifest, not the review body). swamp accepts the edited body without any tamper/integrity complaint.
Re-run the same dry-run push. Now the output carries:

{
  "ruleId": "adversarial-review-report",
  "dimension": "Adversarial review",
  "severity": "medium",
  "file": ".../_jentz_aws-stackset-audit-590d4...json",
  "message": "Dimension <id> flagged ISSUE: <the dimension's note>."
}

The .file points at the already-committed, already-correct review.

Expected

A present, hash-matching, completed review should be distinguishable from a missing/stale one. Options that would fix the ambiguity:

Use a distinct ruleId (or a status field) for "review complete, a dimension recorded an issue" vs "review missing/stale", and/or
Omit .file in the issue-verdict case (there is no file action that clears it), and/or
Document explicitly whether an issue verdict is meant to be gate-blocking.

Why it matters

Because the two states are indistinguishable in the warning payload, any CI gate built on reviewRuleWarnings[].ruleId == "adversarial-review-report" (the pattern in swamp's own CI-artifact docs) treats an honest issue verdict as a failure. That structurally pressures reviewers to launder real issue findings into pass-with-a-disclosure-note — we observed exactly this: every committed review in our repo uses only pass/na, never issue, to keep the gate green. The feature that records honest issues ends up unused.

Note

Possibly working-as-intended (an issue verdict should draw attention). If so, the ask reduces to: give consumers a way to distinguish "review owed" from "review done, issue noted" — e.g. a separate ruleId or an explicit verdict/status field on the warning — so a gate can pass a completed review regardless of verdict while still surfacing the note.

02Bog Flow

Shipped

7/19/2026, 7:48:29 PM

Click a lifecycle step above to view its details.

03Sludge Pulse

keeb assigned keeb7/19/2026, 6:27:45 PM

keeb commented 7/19/2026, 7:48:30 PM

Thanks @jentz for reporting this! The fix has been merged and a release is on its way. We appreciate your contribution to swamp.

Bundled extension model cannot deserialize AWS SDK S3 XML that works in direct Deno

gcp/sheets spreadsheets-values: batch_get crashes with "Request with GET/HEAD method cannot have body"

Token creation API and UI scope selector for collective tokens (phase 4 of #960)

Make Cloudflare CRUD methods factory-aware so list-discovered resources can be managed in-place

Add @swamp/kubernetes/statefulset model type

serve: workflow.approvals and workflow.run.search still full-scan the workflow-run store after the #1284 data.query pushdown

Sync guard skips bound namespace directory during push — 0 files pushed after namespace migrate

Flaky #1052 preparePush test: mtime-granularity race on Linux tmpfs

command/shell renders JSON-object stdout lines as the literal string 'undefined'

Issue redactor treats the MongoDB authSource parameter as a secret, corrupting reproduction steps

namespace unset --migrate silently deletes artifact history via catalog-rebuild GC (~484k files lost)

Docs: document repo root resolution from subdirectories

Expose the swamp.club feed as an RSS feed

Email invitation is not linked to account created from invite URL

Add serve, datastore, vault, and worker wildcard scopes to token registry (phase 4 prep, #960)

datastore setup extension drops 'namespace' from --config, making extensions that require it impossible to configure

Docs: update manual to document --yes/-y as the standard confirmation-skip flag

Docs: update data.query and CEL expressions references for SQL pushdown

Docs: document collective token CLI usage in API key authentication pages

Add a --release-notes option to `swamp update` (or even make it the default)

Docs: manual should state workflow unknown keys are rejected and placement is step-only (follow-up to #1240)

Make GCP CRUD methods factory-aware so list-discovered resources can be managed in-place

serve: read ops (data.query, workflow.approvals, workflow run.search) linearly scan the whole datastore — ~350–600ms floor regardless of match count

Running "swamp workflow run ..." in a subdir of the swamp repo fails

Guide agents to inspect reports after failed model and workflow runs

serve: main JS thread holds ~40–70% of a core while idle (no clients, no runs, --no-schedule)

Search box collapses to near-zero width on mobile on the Extensions page

Extensions page: Search bar missing on mobile

spreadsheets-values: every method fails with 'Missing required path parameter: spreadsheetId' — implementation reads a global argument the schema does not declare

namespace migrate/set workflow broken for extension datastores: migrate skipped by sync guard, set not idempotent, migrate-index empties shards

ExtensionInfo.latestVersion typed 'string' but registry returns null; harden pull/resolve for prerelease-only extensions

workflow.run: relay a custom model method's output as method_output (command steps already do)

promptChoice infinite-loops on non-interactive stdin

gcp _lib: unconditional x-goog-user-project header causes USER_PROJECT_DENIED (403) for service accounts without the serviceUsageConsumer role

extension push: issue-verdict review is indistinguishable from missing/stale

swamp extension version crashes with 'Invalid CalVer version: "null"' when only a prerelease (beta/rc) version is published

Pushing an extension after creating a public git repo that is the same as other previously pushed extensions doesn't update the "Verified public repository"

`datastore setup filesystem` never transfers content when leaving a sync-based (remote) datastore — copies only the catalog and hardcodes `filesPulled: 0`

Scaleway models: create methods should not require the resource ID they generate (ipId/gatewayId/serverId/...)

gcp/calendar events.list reads wrong array field ('defaultReminders' not 'items') → always returns 0 events

provisioner.provision fails with 'Cannot read properties of undefined (reading trim)' at method_execution_service.ts:852

method_execution_service.ts:852 crashes on undefined.trim() when writeResource receives undefined instance name

CLI support for collective API tokens (phase 3 of #960)

@swamp/gcp/calendar: service-account & ADC auth mint cloud-platform-scoped tokens → 403 on Calendar API

Scope enforcement and whoami introspection for collective tokens (phase 2 of #960)

fix(software-factory): DeclaredSchemaSchema.enum rejects boolean literals

Surface cloud-provider labels (scaleway, digitalocean, oracle/oci) as first-class search/filter facets on the Extensions page

Profile link in genesis subdirectory does not navigate back to main profile

Profile stats: per-user daily rollup table + MV in ClickHouse

Reconcile collective-token CLI activity to members (attribute → bonus → stamp → even-split)

Telemetry stats consumer: unsanitized subcommand in Mongo update path drops user metrics silently

Telemetry stats consumer: insert_id dedup commits before the write it guards — any upsert failure is silently swallowed on retry

Job-level labels: block is silently ignored, not rejected

Issue submission redactor silently corrupts report bodies

CLI telemetry: fold third-level verbs into subcommand + canonicalize aliases

Docs: update extension info reference to document extensions (type grafts) in content metadata

Docs: swamp skill repo-structure reference still documents repo-local .swamp/telemetry/ as live

Add safe adoption and lifecycle methods for existing Hetzner resources

Docs: update manual telemetry reference for user-global spool and telemetry.yaml opt-out

export const extension can graft methods onto foreign-collective types, undisclosed in extension info / contentMetadata

Add lookup support to the Cloudflare DNS records model

Expand token scope registry to full taxonomy (phase 1 addendum, #960)

Docs: document user-global telemetry (telemetry.yaml opt-out, spool location, telemetry stats behavior)

score_daily rollup strands stale grains when a day-less grant re-stamps onto a later day

swamp-club: global rate limiter runs pre-auth and collapses all direct clients into one per-IP bucket — 429s authenticated CLI traffic

Collective API token scopes: domain, persistence, and auth threading (phase 1 of #960)

Telemetry migration from ~/.swamp/telemetry should auto-detect home-as-repo

feed_post_score_events queue grows unboundedly (no TTL, no delete-on-delivery)

Issue-filing skill should require ownership classification before submitting a bug

Interactive finder silently drops the preview pane on narrower terminals, and layout selection is unstable

@-mention autocomplete for users when writing lab ripples

Remove comments from /feed and redesign the page

Interactive finder preview corrupts: overlapping/stale lines when preview content overflows the pane

Score-refresh consumer: harden coalescing against a diverse backlog (bistability)

Remove feed comments — consolidate discussion in Discord

Add a 'my collective extensions' filter to extensions page

Relax the profanity filter

Extension search returns edit-distance noise for short queries ("asdl" → "AWS DEADLINE")

Telemetry recoverOrphaned startup race with multiple replicas (created_at-based)

Telemetry retry/failed path has the same non-atomic claim as #820

Grant revoke is never applied to the running server — under `--grant-reload auto` and `manual` alike, a revoked grant stays in force until an explicit `access reload`