Skip to main content
← Back to list
01Issue
FeatureShippedExtensions
Assigneesstack72

Relationships

#792 Add `vault delete` support to @swamp/aws-sm extension

Opened by stack72 · 6/23/2026· Shipped 6/24/2026

Summary

The swamp vault delete command was added in #1654, using the opt-in VaultDeleteProvider interface pattern. The built-in local encryption vault provider already implements this interface, but the @swamp/aws-sm extension does not yet support it.

What needs to happen

The AwsSmVaultProvider in swamp-extensions/vault/aws-sm/extensions/vaults/aws_sm.ts needs to:

  1. Implement the VaultDeleteProvider interface by adding a delete(secretKey: string): Promise<void> method
  2. Update the createProvider() factory return type to include VaultDeleteProvider
  3. Use the AWS SDK DeleteSecretCommand to delete the secret from Secrets Manager (consider whether to use ForceDeleteWithoutRecovery or the default 30-day recovery window — probably best to use the default and document it)
  4. Add tests for the new delete functionality

Reference

  • VaultDeleteProvider interface: src/domain/vaults/vault_provider.ts
  • isVaultDeleteProvider type guard: same file — used at runtime to detect delete support
  • Built-in implementation example: src/domain/vaults/local_encryption_vault_provider.ts (delete method)
  • CLI command: src/cli/commands/vault_delete.ts

Labels

enhancement


Automoved by swampadmin from https://github.com/swamp-club/swamp/issues/1664

02Bog Flow
OPENTRIAGEDIN PROGRESSSHIPPED+ 1 MOREASSIGNED+ 5 MOREREVIEW+ 3 MOREPR_MERGED+ 1 MORENOTIFICATION_SKIPPED

Shipped

6/24/2026, 12:16:23 AM

Click a lifecycle step above to view its details.

03Sludge Pulse
stack72 assigned stack726/23/2026, 11:46:08 PM

Sign in to post a ripple.