Skip to main content
← Back to list
01Issue
BugShippedSwamp CLI
Assigneesstack72

Relationships

#1027 CI: review jobs check stale global state, causing cross-reviewer blocking

Opened by stack72 · 7/8/2026· Shipped 7/8/2026

Problem

The Fail if changes requested step in each Claude review job (claude-review, claude-adversarial-review, claude-ux-review, claude-ci-security-review) checks the last github-actions review globally:

[.reviews[] | select(.author.login == "github-actions")] | last | .state

Since all four reviewers post as github-actions, a CHANGES_REQUESTED from the adversarial reviewer blocks the UX reviewer's pass check — even when the UX reviewer itself approved. This caused PR #1788 to require a force merge despite all reviewers passing on the final code.

Fix

Each job should filter reviews by its own body prefix instead of checking the global last state. Each reviewer already uses a distinct heading:

  • Code Review: ## Code Review
  • Adversarial: ## Adversarial Review
  • CLI UX: ## CLI UX Review
  • CI Security: ## CI Security Review

The Fail if changes requested step should filter to reviews whose body starts with the job's heading, then check the last one's state. Example for the adversarial job:

latest_state=$(gh pr view $PR \
  --json reviews \
  --jq '[.reviews[] | select(.author.login == "github-actions" and (.body | startswith("## Adversarial Review")))] | last | .state')

Files

  • .github/workflows/ci.yml — all four Fail if changes requested steps
  • .github/actions/adversarial-review/action.yml — the adversarial review's fail step

Impact

Without this fix, any multi-round review on a PR with multiple reviewer jobs risks stale cross-reviewer blocking, requiring manual dismissal or admin merge override.


Automoved by swampadmin from https://github.com/swamp-club/swamp/issues/1791

02Bog Flow
OPENTRIAGEDIN PROGRESSSHIPPED+ 1 MOREASSIGNED+ 7 MOREREVIEW+ 4 MOREPR_MERGED+ 1 MORENOTIFICATION_SKIPPED

Shipped

7/8/2026, 7:42:20 PM

Click a lifecycle step above to view its details.

03Sludge Pulse
stack72 assigned stack727/8/2026, 4:55:40 PM

Sign in to post a ripple.