Skip to main content
← Back to list
01Issue
BugOpenExtensionsPublic
AssigneesNone

Relationships

#1923 Software factory ignores earlier approvals with multiple cycle overrides

Opened by annie · 8/31/2026

Summary

The software factory can incorrectly remain blocked when a run has multiple cycle overrides. Approval records and their notes are stored, but gate evaluation recognizes only the latest approval record.

Reproduction

  1. Drive a factory run beyond the configured cycle limit for one stage and record a cycle override approval.
  2. Continue the run until another stage requires a separate cycle override.
  3. Record the second override approval.
  4. Refresh factory status.

Actual behavior

Only one override is recognized. The earlier approval still exists in version history, but the run remains blocked because the approval loader reads latest-only catalog results.

Expected behavior

All approval records applicable to the current run should be loaded and evaluated, including their actor, note, stage, and cycle scope.

Root cause

The software-factory approval loader used findAllForModel, whose current catalog behavior returns only the latest version. Approval history requires complete resource version enumeration.

Proposed fix

Load approval records with repo.listVersions(), then evaluate every stored approval version. A regression test should record multiple cycle overrides and assert that both are recognized.

Validation

A patch replacing the latest-only lookup with repo.listVersions() passed deno task check, deno task lint, deno task fmt:check, and all 164 extension tests. The corrected engine immediately recognized both existing override approvals in the affected run.

Reference implementation

A reviewed patch is available in anniehedgpeth/swamp-extensions PR 1, merged as commit [REDACTED-SECRET-1].

Upstream repository: https://github.com/swamp-club/swamp-extensions

Environment

  • Extension: @swamp/software-factory@2026.06.24.1
  • swamp: 20260827.012103.0-sha.89734f5f
  • OS: darwin (aarch64)
  • Deno: 2.8.3
  • Shell: /bin/zsh
02Bog Flow
OPENTRIAGEDIN PROGRESSSHIPPED

Open

8/31/2026, 11:19:44 PM

No activity in this phase yet.

03Sludge Pulse

Sign in to post a ripple.