Skip to main content
← Back to list
01Issue
BugClosedSwamp CLIPublic
AssigneesNone

Relationships

#2322 agent-constraints: planning-conventions CI fan-out checklist points at jobs that no longer live in ci.yml

Opened by hammz · 9/21/2026

Problem

agent-constraints/planning-conventions.md ("CI Fan-Out Checklist") tells plans that add a new extension or scope directory to update, in .forgejo/workflows/ci.yml:

  • the changes job's paths-filter filters
  • the matching matrix job's matrix.<extension> list
  • the matching *-lockfile job's matrix
  • the claude-review job's needs: list
  • the claude-adversarial-review job's needs: list
  • the deps-audit job's find expression "around line 508"

None of the first five exist in ci.yml any more. ci.yml is 63 lines and holds exactly three jobs: deps-audit, actions-audit, gate. The per-scope matrices were split into ci-datastores.yml (datastore: [s3, gcs]), ci-vaults.yml, ci-models.yml and ci-extensions.yml; the review jobs moved to ci-reviews.yml, where they gate on a changes job local to that file rather than on a needs: list of per-scope jobs. The deps-audit find expression is real but sits at line 29, not 508.

Impact

The checklist is load-bearing during issue-lifecycle planning — it is read verbatim to decide whether a plan needs CI changes, and the adversarial review has a ci-matrix-completeness dimension that scores plans against it. A plan that adds an extension and follows it will look for matrices that are not there, and may conclude no CI change is needed when ci-datastores.yml or its siblings genuinely need the new entry. The claude-review / claude-adversarial-review needs: guidance is the worst case, since the checklist itself names a skipped review as the worst outcome.

Proposed fix

Rewrite the checklist against the current workflow layout: name the per-scope file for each scope, describe how ci-reviews.yml actually triggers, and drop the stale line number in favour of naming the deps-audit directory list. Same for the ci-matrix-completeness dimension in agent-constraints/adversarial-dimensions.md, which repeats the same structure.

Provenance

Surfaced during adversarial review of the plan for swamp-club#2315 (GCS conditional-write probe) as finding ADV-6. That plan needed no CI change either way — datastore/gcs is already in both ci-datastores.yml matrices — so it was filed out rather than folded in.

02Bog Flow
✓OPEN○TRIAGED○IN PROGRESS◉CLOSED

Closed

9/21/2026, 6:44:17 PM

No activity in this phase yet.

03Sludge Pulse
Editable. Press Enter to edit.

stack72 commented 9/21/2026, 6:44:16 PM

I will replace this with the new verification changes today so lets not do anything here

Sign in to post a ripple.